fix: apply backward-compat rule for empty EventType in buildReportData#434
Merged
claude[bot] merged 1 commit intomainfrom Mar 1, 2026
Merged
fix: apply backward-compat rule for empty EventType in buildReportData#434claude[bot] merged 1 commit intomainfrom
claude[bot] merged 1 commit intomainfrom
Conversation
Entries with empty EventType (created in tests or old log files without event_type) were silently discarded by buildReportData. Apply the same backward-compat rule already used in ReadAll: treat empty EventType as EventRun. Fixes 5 failing report tests that construct entries without EventType. Co-Authored-By: Grey Newell <greyshipscode@gmail.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: claude[bot] <claude[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildReportData in cmd/report.go was silently discarding activitylog.Entry values where EventType is empty (the zero value), treating them as non-EventRun events.
This applies the same backward-compatibility rule already used in activitylog.ReadAll(): treat an empty EventType as EventRun.
Changes
Fixes
5 failing tests in cmd/report_test.go:
Closes #431
Generated with Claude Code